Fix ci for mongoose in node 14 #3758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 5.44 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3758 +/- ##
==========================================
- Coverage 85.10% 85.08% -0.03%
==========================================
Files 227 227
Lines 9299 9293 -6
Branches 33 33
==========================================
- Hits 7914 7907 -7
- Misses 1385 1386 +1 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BenchmarksBenchmark execution time: 2023-11-02 12:15:29 Comparing candidate commit bee15bd in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 483 metrics, 9 unstable metrics. |
juan-fernandez
previously approved these changes
Nov 2, 2023
CarlesDD
previously approved these changes
Nov 2, 2023
CarlesDD
approved these changes
Nov 2, 2023
uurien
added a commit
that referenced
this pull request
Nov 2, 2023
uurien
added a commit
that referenced
this pull request
Nov 2, 2023
uurien
added a commit
that referenced
this pull request
Nov 3, 2023
uurien
added a commit
that referenced
this pull request
Nov 3, 2023
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Model.countmethod tests from last mongoose in all node versions.Motivation
??=, it is not supported in node 14.CI execution in v3.x branch: PR (to delete): #3757
plugin: https://github.com/DataDog/dd-trace-js/actions/runs/6729875788/job/18291540975?pr=3757
appsec: https://github.com/DataDog/dd-trace-js/actions/runs/6729875798/job/18291534934?pr=3757